Changeset 1180

Timestamp:

May 11, 2011, 9:17:45 AM (14 years ago)

Author:

Sam Habiel

Message:

RemoteSession.cs Interface: Added:

• Lock method to lock glvns on M db.
• Encoding ConnectionEncoding to set the connection encoding on the DB

BMXNetSessionConnection: Added:

• Abstract ConnectionEncoding property
• Clarified error message that gets called. It now says that you don't have TransmitRPC writer lock??? When the error could be any BMXNetException.

BMXNetSessionSocketConnection:

• Added ConnectionEncoding property
• ReceiveString completely refactored: now we get much better performance
• Timers and Debug Writes are all over the place now.

BMXNetRemoteSession:

• Implemented the 2 new 'stuff' in Interface RemoteSesssion: -- Lock glvn -- Encoding Property
• TableFromSQL with Dataset has an honest to god bug in it: The passed dataset and table name are not used even though they are passed.

BMXNetSessionConnectionOverAnotherSessionConnection:

• Implemented the Encoding Property in Interface RemoteSession to have the project compile.

Updated dlls. Have fun.

Location:

BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework

Files:

• IndianHealthService.BMXNet/BMXNetSessionConnection.cs (modified) (2 diffs)
• IndianHealthService.BMXNet/Net/BMXNetSessionSocketConnection.cs (modified) (12 diffs)
• IndianHealthService.BMXNet/RemoteSession.cs (modified) (2 diffs)
• IndianHealthService.BMXNet/Sevices/BMXNetRemoteSession.cs (modified) (4 diffs)
• IndianHealthService.BMXNet/Sevices/BMXNetSessionConnectionOverAnotherSessionConnection.cs (modified) (1 diff)
• IndianHealthService.BMXNet/bmxnet.xml (modified) (1 diff)
• Release/BMXEHR40.dll (modified) ( previous)
• Release/BMXNET40.dll (modified) ( previous)
• Release/BMXWIN40.dll (modified) ( previous)

BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework/IndianHealthService.BMXNet/BMXNetSessionConnection.cs

@@ -441 +441 @@
         public abstract int ReceiveTimeout { get; set; }
         public abstract int SendTimeout { get; set; }
+        public abstract Encoding ConnectionEncoding { get; set; }
 
 
@@ -469 +470 @@
                 // The writer lock request timed out.
                 //TODO: Remark: to writer lock for Transmit RPC
-                Debug.Write("TransmitRPC writer lock request timed out.\n");
+                //SMH: Wrong error message. We do have an exception, but nothing to do with a lock.
+                //Debug.Write("TransmitRPC writer lock request timed out.\n");
+                Debug.Write("Exception: " + exception.Message);
                 throw exception;
             }

BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework/IndianHealthService.BMXNet/Net/BMXNetSessionSocketConnection.cs

@@ -24 +24 @@
         public static int DefaultReceiveTimeout = 40000;
         
+        
         private int _sendTimeout = 0;
 
@@ -63 +64 @@
         }
 
+        public override Encoding ConnectionEncoding // Default Encoding determined by Windows; typically a Windows Code Page
+        {
+            get;
+            set;
+        }
+            
+
                 public BMXNetSessionSocketConnection(BMXNetBroker aBroker):base(aBroker)
                 {
@@ -70 +78 @@
                         m_sWISH = "";
                         m_cHDR = ADEBHDR(m_sWKID,m_sWINH,m_sPRCH,m_sWISH);
+
+            ConnectionEncoding = Encoding.Default;
 
                 }
@@ -218 +228 @@
         }
 
-
-
-
         bool m_bLogging = false;
 
@@ -239 +246 @@
             {
                 String cMSG = ADEBLDMsg(m_cHDR, "BMX CONNECT STATUS", "");
-
+#if DEBUG
+                _watch = new Stopwatch();
+                _watch.Start();
+#endif
                 this.SendString(this.Socket, cMSG);
                 String strReceive = ReceiveString(this.Socket);
+#if DEBUG
+                _watch.Stop();
+
+                Debug.WriteLine("Time: " + _watch.ElapsedMilliseconds + " ms");
+                Debug.WriteLine("---");
+                _watch = null;
+#endif
+
                 String port = BMXNetBroker.Piece(strReceive, "|", 1);
                 String message = BMXNetBroker.Piece(strReceive, "|", 2);
@@ -275 +293 @@
         }
 
-     
+        Stopwatch _watch = new Stopwatch();
+
         protected override String SendReceiveString(string cSendString, string cMult)
         {
 #if DEBUG
-            Stopwatch _watch = new Stopwatch();
+            _watch = new Stopwatch();
             _watch.Start();
-            Debug.WriteLine("Sending (T:" + Thread.CurrentThread.ManagedThreadId + "): " + cSendString);
 #endif
             this.SendString(this.m_pCommSocket, cSendString, cMult);
+            Debug.WriteLine("Time After Send: " + _watch.ElapsedMilliseconds + " ms");
             string _received = this.ReceiveString(this.m_pCommSocket);
 #if DEBUG
-            Debug.WriteLine("Received(T:" + Thread.CurrentThread.ManagedThreadId + "): " + _received.Replace((char) 30, (char) 10));
+            _watch.Stop();
+
             Debug.WriteLine("Time: " + _watch.ElapsedMilliseconds + " ms");
             Debug.WriteLine("---");
@@ -303 +323 @@
         protected virtual void SendString(TcpClient tcpClient, string cSendString, string cMult)
                 {
+#if DEBUG
+            Debug.WriteLine("Sending (T:" + Thread.CurrentThread.ManagedThreadId + "): " + cSendString);
+#endif
             String encodedString = this.EncodeSendString(cSendString, cMult);
                 
                         NetworkStream ns = tcpClient.GetStream();
             ns.WriteTimeout = this.SendTimeout;
-                        byte[] sendBytes = Encoding.ASCII.GetBytes(encodedString);
+                        byte[] sendBytes = ConnectionEncoding.GetBytes(encodedString);
                         ns.Write(sendBytes,0,sendBytes.Length);
             if (this.m_bLogging == true)
@@ -319 +342 @@
                 private string ReceiveString(TcpClient tcpClient)
                 {
-                        NetworkStream ns = tcpClient.GetStream();
+#if DEBUG
+            Debug.WriteLine("Time At Start of Receive: " + _watch.ElapsedMilliseconds + " ms");
+#endif
+
+            NetworkStream ns = tcpClient.GetStream();
+            ns.ReadTimeout = this.ReceiveTimeout; //Timeout; throw exception automatically if we time out.
+
+            MemoryStream mStream = new MemoryStream(1500); // Auto expanding memory storage for what we receive
+            int numberOfBytesRead = 0;  
+            bool bFinished = false;  // Have we found the End of Transmission (ASCII 4) yet?
+
+            // Main Read Loop
+            while (!bFinished) //while we are not done
+            {
+                byte[] bReadBuffer = new byte[1500];        //buffer size = MTU. Message MUST be smaller.
+                numberOfBytesRead = ns.Read(bReadBuffer, 0, bReadBuffer.Length);    //read data
+                bFinished = FindChar(bReadBuffer, (char)4) > -1;                    //look for the EOT (ASCII 4) character
+                if (!bFinished) mStream.Write(bReadBuffer, 0, numberOfBytesRead);  //if we are not done, put the whole stream in
+                else mStream.Write(bReadBuffer, 0, numberOfBytesRead - 1);           //otherwise, number of bytes minus the $C(4) at the end
+            }
+            
+            //Read Security S-Packet
+            mStream.Seek(0, SeekOrigin.Begin);
+            int secLength = mStream.ReadByte();
+            byte[] secBytes = new byte[secLength];
+            if (secLength > 0)
+            {
+                mStream.Read(secBytes, 0, secLength);
+            }
+
+            //Read Error S-Packet
+            mStream.Seek(secLength + 1, SeekOrigin.Begin);
+            int errLength = mStream.ReadByte();
+            byte[] errBytes = new byte[errLength];
+            if (errLength > 0)
+            {
+                mStream.Read(errBytes, 0, errLength);
+            }
+
+            //If either one of these exists, then we have an error on the Mumps Database
+            if (secLength > 0 || errLength > 0)
+            {
+                string errString = ConnectionEncoding.GetString(secBytes);
+                string appString = ConnectionEncoding.GetString(errBytes);
+                throw new BMXNetException("Mumps Database Security/Error: " + errString + " | " + appString);
+            }
+
+            //No Errors. Decode the entire message starting from after the S packets above
+            string sReadBuffer = ConnectionEncoding.GetString(mStream.ToArray(), secLength + errLength + 2, mStream.ToArray().Length - (secLength + errLength + 2)); //decode
+
+            String decodedReceiveString = this.DecodeReceiveString(sReadBuffer);
+
+            if (this.m_bLogging)
+            {
+                Log("Received: " + decodedReceiveString, this.m_LogWriter);
+            }
+#if DEBUG
+            Debug.WriteLine("Time At End of Receive: " + _watch.ElapsedMilliseconds + " ms");
+            Debug.WriteLine("Received(T:" + Thread.CurrentThread.ManagedThreadId + "): " + decodedReceiveString.Replace((char)30, (char)10));
+#endif
+            return decodedReceiveString;
+            
+
+            /* OLD CODE
+            NetworkStream ns = tcpClient.GetStream();
             ns.ReadTimeout = this.ReceiveTimeout;
 
@@ -409 +496 @@
                 Log("Received: " + decodedReceiveString, this.m_LogWriter);
             }
+#if DEBUG
+            Debug.WriteLine("Time At End of Receive: " + _watch.ElapsedMilliseconds + " ms");
+#endif
             return decodedReceiveString;
-                        
+                        */
                 }
 
@@ -422 +512 @@
                         //Build AV Call
                         cMSG = ADEBLDMsg(m_cHDR, "BMX AV CODE", winIdentity.Name);
+#if DEBUG
+            _watch = new Stopwatch();
+            _watch.Start();
+#endif
             SendString(this.Socket, cMSG);
-
             strReceive = ReceiveString(this.Socket);
+#if DEBUG
+            _watch.Stop();
+
+            Debug.WriteLine("Time: " + _watch.ElapsedMilliseconds + " ms");
+            Debug.WriteLine("---");
+            _watch = null;
+#endif
+
                         sTest = strReceive.Substring(0,3);
 
@@ -453 +554 @@
                 
                         cMSG = ADEBLDMsg(m_cHDR, "XUS AV CODE", encryptedAccessVerifyCode);
+#if DEBUG
+            _watch = new Stopwatch();
+            _watch.Start();
+#endif      
             SendString(this.Socket, cMSG);
-
             strReceive = ReceiveString(this.Socket);
+#if DEBUG
+            _watch.Stop();
+
+            Debug.WriteLine("Time: " + _watch.ElapsedMilliseconds + " ms");
+            Debug.WriteLine("---");
+            _watch = null;
+#endif
 
             if (strReceive.StartsWith("M ERROR="))
@@ -519 +630 @@
                                         throw new BMXNetException("BMXNetBroker is not connected to RPMS");
                                 }
-
+#if DEBUG
+                _watch = new Stopwatch();
+                _watch.Start();
+#endif      
                 this.SendString(this.Socket, ADEBLDMsg(m_cHDR, "BMXGetFac", aDuz));
                 return this.ReceiveString(this.Socket);
+#if DEBUG
+                _watch = new Stopwatch();
+                _watch.Start();
+#endif
+
                         }
                         catch (BMXNetException bmxEx)

BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework/IndianHealthService.BMXNet/RemoteSession.cs

@@ -47 +47 @@
         /// </example>
         String AppContext { get; set; }
+
+        Encoding ConnectionEncoding { get; set; }
 
         #endregion
@@ -680 +682 @@
         /// <param name="aString">The command to be examined</param>
         /// <returns>True if it complied, otherwise false</returns>
-        bool IsBmxAdoCommand(String aString); 
+        bool IsBmxAdoCommand(String aString);
+
+        /// <summary>
+        /// Locks a Name on the Mumps Database
+        /// </summary>
+        /// <param name="g/lvnToLock">Global or Local Name to Lock</param>
+        /// <param name="addOrSubstract">+ or - to increment or decrement the lock</param>
+        /// <returns>true for success; false for failure</returns>
+        bool Lock(string lvnToLock, string addOrSubstract);
+
         #endregion
 

BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework/IndianHealthService.BMXNet/Sevices/BMXNetRemoteSession.cs

@@ -1 +1 @@
 using System;
 using System.Data;
+using System.Text;
 using System.Windows.Forms;
 using IndianHealthService.BMXNet.Model;
@@ -76 +77 @@
         }
 
+        public Encoding ConnectionEncoding
+        {
+            get
+            {
+                return SessionConnection.ConnectionEncoding;
+            }
+            set
+            {
+                SessionConnection.ConnectionEncoding = value;
+            }
+        }
+
         public bool IsEventPollingEnabled
         {
@@ -509 +522 @@
         }
 
+        //smh: THIS IS WRONG. If you pass the data set, why make a new dataset...
         public DataTable TableFromSQL(string sql, DataSet aDataSet, string aTableName)
         {
-            return this.TableFromSQL(sql, new DataSet(), this.DefaultTableName, this.AppContext);
+            return this.TableFromSQL(sql, aDataSet, aTableName, this.AppContext);
         }
 
@@ -1070 +1084 @@
             }                    
         }
+
+        public bool Lock(string lvnToLock, string addOrSubstract)
+        {
+            return SessionConnection.Lock(lvnToLock, addOrSubstract);
+        }
     }
 }

BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework/IndianHealthService.BMXNet/Sevices/BMXNetSessionConnectionOverAnotherSessionConnection.cs

@@ -35 +35 @@
         }
 
+        public override Encoding ConnectionEncoding
+        {
+            get;
+            set;
+        }
+
         public override void Close()
         {

BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework/IndianHealthService.BMXNet/bmxnet.xml

@@ -1051 +1051 @@
             <param name="aString">The command to be examined</param>
             <returns>True if it complied, otherwise false</returns>
+        </member>
+        <member name="M:IndianHealthService.BMXNet.RemoteSession.Lock(System.String,System.String)">
+            <summary>
+            Locks a Name on the Mumps Database
+            </summary>
+            <param name="g/lvnToLock">Global or Local Name to Lock</param>
+            <param name="addOrSubstract">+ or - to increment or decrement the lock</param>
+            <returns>true for success; false for failure</returns>
         </member>
         <member name="M:IndianHealthService.BMXNet.RemoteSession.Close">