Changeset 1193 for BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework/IndianHealthService.BMXNet

Timestamp:

May 26, 2011, 5:45:42 AM (13 years ago)

Author:

Sam Habiel

Message:

BMXNetEhrSessionConnection.cs implements ConnectionEncoding so that the project can compile.
BMXNetEhrSessionConnection.cs: ReceiveString TCP code refactored, AGAIN!

Updated dlls.

File:

• BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework/IndianHealthService.BMXNet/Net/BMXNetSessionSocketConnection.cs (modified) (5 diffs)

BMXNET_RPMS_dotNET_UTILITIES-BMX/branch/IHS BMX Framework/IndianHealthService.BMXNet/Net/BMXNetSessionSocketConnection.cs

@@ -10 +10 @@
 using System.Threading;
 using System.Timers;
+using System.Linq;
 
 namespace IndianHealthService.BMXNet.Net
@@ -115 +116 @@
      Port = "All",
      Transport = "All")]
-                protected virtual void OpenConnectionCommon()
+        protected virtual void OpenConnectionCommon()
                 {
                         try
@@ -346 +347 @@
 #endif
 
+            /******************INIT*****************/
             NetworkStream ns = tcpClient.GetStream();
             ns.ReadTimeout = this.ReceiveTimeout; //Timeout; throw exception automatically if we time out.
 
+            /*************SECURITY S-PACKET READ***********************/
+            int secPackLen = ns.ReadByte();  //Read S-Pack Length Byte
+            byte[] secPackContents = new byte[secPackLen];;
+            if (secPackLen > 0)
+            {
+                ns.Read(secPackContents, 0, secPackLen);
+            }
+
+            /****************ERROR S-PACKET READ******************/
+            int errPackLen = ns.ReadByte(); //Read S-Pack Length Byte
+            byte[] errPackConents = new byte[errPackLen];;
+            if (errPackLen > 0)
+            {
+                ns.Read(errPackConents, 0, errPackLen);
+            }
+
+            //If either one of these exists, then we have an error on the Mumps Database
+            if (secPackLen > 0 || errPackLen > 0)
+            {
+                //We still have to read the Data to empty the tcp OS buffers even if we have security/errors in the DB
+                while (ns.DataAvailable) ns.ReadByte() ;  //while loop to empty the buffer -- this is theoretically slow, but that's not important here
+
+                //Now decode them.
+                string secString = ConnectionEncoding.GetString(secPackContents);
+                string errString = ConnectionEncoding.GetString(errPackConents);
+                throw new BMXNetException("Mumps Database Security/Error: " + secString + " | " + errString);
+            }
+
+            /*****************DATA STREAM READ*******************/
+            //Data stream from VISTA ends when we find the EOT (ASCII 4) character
             MemoryStream mStream = new MemoryStream(1500); // Auto expanding memory storage for what we receive
-            int numberOfBytesRead = 0;  
+            int numberOfBytesRead = 0;
             bool bFinished = false;  // Have we found the End of Transmission (ASCII 4) yet?
 
@@ -362 +394 @@
                 else mStream.Write(bReadBuffer, 0, numberOfBytesRead - 1);           //otherwise, number of bytes minus the $C(4) at the end
             }
+
+            //At this point, we are done reading from the Network Stream. Now we have to decode the data.
             
-            //Read Security S-Packet
-            mStream.Seek(0, SeekOrigin.Begin);
-            int secLength = mStream.ReadByte();
-            byte[] secBytes = new byte[secLength];
-            if (secLength > 0)
-            {
-                mStream.Read(secBytes, 0, secLength);
-            }
-
-            //Read Error S-Packet
-            mStream.Seek(secLength + 1, SeekOrigin.Begin);
-            int errLength = mStream.ReadByte();
-            byte[] errBytes = new byte[errLength];
-            if (errLength > 0)
-            {
-                mStream.Read(errBytes, 0, errLength);
-            }
-
-            //If either one of these exists, then we have an error on the Mumps Database
-            if (secLength > 0 || errLength > 0)
-            {
-                string errString = ConnectionEncoding.GetString(secBytes);
-                string appString = ConnectionEncoding.GetString(errBytes);
-                throw new BMXNetException("Mumps Database Security/Error: " + errString + " | " + appString);
-            }
-
-            //No Errors. Decode the entire message starting from after the S packets above
-            string sReadBuffer = ConnectionEncoding.GetString(mStream.ToArray(), secLength + errLength + 2, mStream.ToArray().Length - (secLength + errLength + 2)); //decode
+            //Decode the entire message.
+            string sReadBuffer = ConnectionEncoding.GetString(mStream.ToArray()); //decode
 
             String decodedReceiveString = this.DecodeReceiveString(sReadBuffer);
@@ -636 +644 @@
                 this.SendString(this.Socket, ADEBLDMsg(m_cHDR, "BMXGetFac", aDuz));
                 return this.ReceiveString(this.Socket);
-#if DEBUG
-                _watch = new Stopwatch();
-                _watch.Start();
-#endif
-
                         }
                         catch (BMXNetException bmxEx)