Changeset 1256 for EDIS/trunk/java/tracking-server-core/src

Timestamp:

Oct 2, 2011, 6:04:40 PM (13 years ago)

Author:

Solomon Blaz

Message:

added guard clauses to VistaLinkSessionDao in case initUser RPC fails

File:

• EDIS/trunk/java/tracking-server-core/src/main/java/gov/va/med/edp/dao/rpc/VistaLinkSessionDao.java (modified) (2 diffs)

EDIS/trunk/java/tracking-server-core/src/main/java/gov/va/med/edp/dao/rpc/VistaLinkSessionDao.java

@@ -5 +5 @@
 import org.springframework.dao.DataAccessException;
 import org.springframework.dao.DataRetrievalFailureException;
+import org.springframework.util.StringUtils;
 import org.w3c.dom.Document;
 import org.w3c.dom.Element;
@@ -55 +56 @@
 
     private Document buildDocument(String result) {
+        if (!StringUtils.hasText(result)) throw new DataRetrievalFailureException("unable to get user info: EDPCTRL RPC(command=initUser) returned an empty response");
+        if (result.contains("error")) throw new DataRetrievalFailureException("unable to get user info: EDPCTRL RPC(command=initUser) returned an error");
         try {
             DocumentBuilder builder = DocumentBuilderFactory.newInstance().newDocumentBuilder();