Changeset 1479 for Scheduling/trunk/m/BSDX25.m

Timestamp:

Jul 9, 2012, 7:43:46 PM (12 years ago)

Author:

Sam Habiel

Message:

Added/fixed the following:

• Unit Tests for running everything through PIMS
• Checks for end of message for error handling ((31))
• All routines previously using transactions use locks now

File:

• Scheduling/trunk/m/BSDX25.m (modified) (8 diffs)

Scheduling/trunk/m/BSDX25.m

@@ -1 @@
-BSDX25  ; VEN/SMH - WINDOWS SCHEDULING RPCS ; 7/5/12 11:55am
+BSDX25  ; VEN/SMH - WINDOWS SCHEDULING RPCS ; 7/9/12 5:00pm
         ;;1.7T1;BSDX;;Jul 06, 2012;Build 18
         ; Licensed under LGPL
@@ -41 +41 @@
         ; -2 -> Invalid Check-in Date
         ; -3 -> Cannot check-in due to Fileman Filer failure
+        ; -4 -> Cannot lock ^BSDXAPPT(APPTID)
         ; -10 -> BSDXAPI error
         ; -100 -> Mumps Error
@@ -66 +67 @@
         I '+BSDXAPPTID D ERR("-1~Invalid Appointment ID") QUIT
         I '$D(^BSDXAPPT(BSDXAPPTID,0)) D ERR("-1~Invalid Appointment ID") QUIT
+        ;
+        ; Lock BSDX node, only to synchronize access to the globals.
+        ; It's not expected that the error will ever happen as no filing
+        ; is supposed to take 5 seconds.
+        L +^BSDXAPPT(BSDXAPPTID):5 E  D ERR("-4~Appt record is locked. Please contact technical support.") QUIT
         ;
         ; Remove Date formatting v.1.5. Client will send date as FM Date.
@@ -101 +107 @@
         . D ERR(-10_"~"_$P(BSDXERR,U,2)) ; Send error message to client
         ;
+        L -^BSDXAPPT(BSDXAPPTID)
         S BSDXI=BSDXI+1
         S ^BSDXTMP($J,BSDXI)="0"_$C(30)
@@ -124 +131 @@
         Q 0
         ;
-RMCI(BSDXY,BSDXAPPTID)  ; EP - Remove Check-in from BSDX APPT and 2/44
+RMCI(BSDXY,BSDXAPPTID)  ; Private EP - Remove Check-in from BSDX APPT and 2/44
         ; Called by RPC BSDX REMOVE CHECK-IN
         ; 
@@ -163 +170 @@
         I '$D(^BSDXAPPT(BSDXAPPTID,0)) D ERR("-2~Invalid Appointment ID") QUIT
         ;
+        ; Lock
+        ; Timeout not expected to happen except in error conditions.
+        L +^BSDXAPPT(BSDXAPPTID):5 E  D ERR("-7~Appt record is locked. Please contact technical support.") QUIT
+        ;
         ; Get appointment Data
         N BSDXNOD S BSDXNOD=^BSDXAPPT(BSDXAPPTID,0)
@@ -199 +210 @@
         . N % S %=$$BSDXCHK(BSDXAPPTID,BSDXCDT) ; No error checking here.
         . D ERR("-5~"_$P(BSDXERR,U,2)) ; Send error message to client
-        ; 
+        ;
+        ; Unlock
+        L -^BSDXAPPT(BSDXAPPTID)
+        ;
         ; Return ADO recordset
         S BSDXI=BSDXI+1
@@ -264 +278 @@
         ;
 ERR(BSDXERR)    ;Error processing
+        ; Unlock first
+        L:$D(BSDXAPPTID) -^BSDXAPPT(BSDXAPPTID)
         ; If last line is $C(31), we are done. No more errors to send to client.
         I ^BSDXTMP($J,$O(^BSDXTMP($J," "),-1))=$C(31) QUIT