Changeset 1479 for Scheduling/trunk/m/BSDX26.m

Timestamp:

Jul 9, 2012, 7:43:46 PM (12 years ago)

Author:

Sam Habiel

Message:

Added/fixed the following:

• Unit Tests for running everything through PIMS
• Checks for end of message for error handling ((31))
• All routines previously using transactions use locks now

File:

• Scheduling/trunk/m/BSDX26.m (modified) (7 diffs)

Scheduling/trunk/m/BSDX26.m

@@ -1 @@
-BSDX26   ; IHS/OIT/HMW - WINDOWS SCHEDULING RPCS ; 6/25/12 4:29pm
+BSDX26   ; IHS/OIT/HMW - WINDOWS SCHEDULING RPCS ; 7/9/12 2:19pm
         ;;1.7T1;BSDX;;Jul 06, 2012;Build 18
         ; Licensed under LGPL
@@ -8 +8 @@
         ;
         ; Error Reference:
-        ; -1: Appt ID is not a number
-        ; -2: Appt IEN is not in ^BSDXAPPT
-        ; -3: FM Failure to file WP field in ^BSDXAPPT
-        ; -4: BSDXAPI reports failure to change note field in ^SC
+        ; 1: Appt ID is not a number
+        ; 2: Appt IEN is not in ^BSDXAPPT
+        ; 3: FM Failure to file WP field in ^BSDXAPPT
+        ; 4: BSDXAPI reports failure to change note field in ^SC
+        ; 5: Failure to acquire lock on ^BSDXAPPT(APPTID)
+        ; 100: Mumps Error
+        ; 
+        ; NB: Normally I use negative numbers for errors; this routine returns
+        ;     -1 as a successful result! So I needed to use +ve numbers.
         ;
 EDITAPTD(BSDXY,BSDXAPTID,BSDXNOTE)       ;EP
@@ -48 +53 @@
         ;
         ; Validate Appointment ID
-        I '+BSDXAPTID D ERR(BSDXI,"-1~BSDX26: Invalid Appointment ID") QUIT
-        I '$D(^BSDXAPPT(BSDXAPTID,0)) D ERR(BSDXI,"-2~BSDX26: Invalid Appointment ID") QUIT
+        I '+BSDXAPTID D ERR(BSDXI,"1~BSDX26: Invalid Appointment ID") QUIT
+        I '$D(^BSDXAPPT(BSDXAPTID,0)) D ERR(BSDXI,"2~BSDX26: Invalid Appointment ID") QUIT
+        ;
+        ; Lock BSDX node, only to synchronize access to the globals.
+        ; It's not expected that the error will ever happen as no filing
+        ; is supposed to take 5 seconds.
+        L +^BSDXAPPT(BSDXAPTID):5 E  D ERR(BSDXI,"5~BSDX08: Appt record is locked. Please contact technical support.") QUIT
         ;
         ; Put the WP in decendant fields from the root to file as a WP field
@@ -65 +75 @@
         ;
         ; Error handling. No need for rollback since nothing else changed.
-        I $D(BSDXMSG) D ERR(BSDXI,"-3~BSDX26: Fileman failure to file data into 9002018.4") QUIT
+        I $D(BSDXMSG) D ERR(BSDXI,"3~BSDX26: Fileman failure to file data into 9002018.4") QUIT
         ;
         ; Now file in file 44:
@@ -73 +83 @@
         N BSDXRES S BSDXRES=0 ; Result
         ; Update Note only if we have a linked hospital location.
-        I HLIEN S BSDXRES=$$UPDATENT^BSDXAPI(PTIEN,HLIEN,DATE,BSDXNOTE(.5))
+        I HLIEN S BSDXRES=$$UPDATENT^BSDXAPI1(PTIEN,HLIEN,DATE,BSDXNOTE(.5))
         ; If we get an error (denoted by -1 in BSDXRES), return error to client
         ; AND restore the original note
-        I BSDXRES<0 D ERR(BSDXI,"-4~BSDX26: BSDXAPI reports an error: "_BSDXRES),ROLLBACK(BSDXAPTID) QUIT
+        I BSDXRES<0 D ERR(BSDXI,"4~BSDX26: BSDXAPI reports an error: "_BSDXRES),ROLLBACK(BSDXAPTID) QUIT
         ;
         ;Return Recordset indicating success
+        L -^BSDXAPPT(BSDXAPTID)
         S BSDXI=BSDXI+1
         S ^BSDXTMP($J,BSDXI)="-1"_$C(30)
@@ -93 +104 @@
         ;
 ERR(BSDXI,BSDXERR)       ;Error processing
+        ; Unlock first
+        L:$D(BSDXAPTID) -^BSDXAPPT(BSDXAPTID)
+        ; If last line is $C(31), we are done. No more errors to send to client.
+        I ^BSDXTMP($J,$O(^BSDXTMP($J," "),-1))=$C(31) QUIT
         S BSDXI=BSDXI+1
         S BSDXERR=$TR(BSDXERR,"^","~")
@@ -103 +118 @@
         N $ET S $ET="D ^%ZTER HALT" ; Emergency Error Trap
         D ^%ZTER
-        S $EC=""
+        ;
         I '$D(BSDXI) N BSDXI S BSDXI=0
-        D ERR(BSDXI,"-100~BSDX26 Error: "_$G(%ZTERZE))
+        D ERR(BSDXI,"100~BSDX26 Error: "_$G(%ZTERZE))
         QUIT