Changeset 1479 for Scheduling/trunk/m/BSDX31.m

Timestamp:

Jul 9, 2012, 7:43:46 PM (12 years ago)

Author:

Sam Habiel

Message:

Added/fixed the following:

• Unit Tests for running everything through PIMS
• Checks for end of message for error handling ((31))
• All routines previously using transactions use locks now

File:

• Scheduling/trunk/m/BSDX31.m (modified) (6 diffs)

Scheduling/trunk/m/BSDX31.m

@@ -1 @@
-BSDX31   ; IHS/OIT/HMW - WINDOWS SCHEDULING RPCS ; 6/27/12 4:57pm
+BSDX31   ; IHS/OIT/HMW - WINDOWS SCHEDULING RPCS ; 7/9/12 12:57pm
         ;;1.7T1;BSDX;;Jul 06, 2012;Build 18
         ; Licensed under LGPL
@@ -20 +20 @@
         ; -5: Filing of No-show in ^DPT failed (BSDXAPI error)
         ; -6: Invalid Resource ID
+        ; -7: Lock not acquired on ^BSDXAPPT(BSDXAPTID)
         ; -100: M Error
         ;
@@ -70 +71 @@
         I '$D(^BSDXAPPT(BSDXAPTID,0)) D ERR(-2,"BSDX31: Invalid Appointment ID") Q
         ;
+        ; Lock BSDX node, only to synchronize access to the globals.
+        ; It's not expected that the error will ever happen as no filing
+        ; is supposed to take 5 seconds.
+        L +^BSDXAPPT(BSDXAPTID):5 E  D ERR(-7,"BSDX31: Appt record is locked. Please contact technical support.") Q
+        ;
         ; Noshow value check - Must be 1 or 0
         S BSDXNS=+BSDXNS
@@ -113 +119 @@
         . D ERR(-5,"BSDX31: "_$P(BSDXERR,U,2))
         . N % S %=$$BSDXNOS(BSDXAPTID,'BSDXNS) ; no error checking for filer
+        ;
+        ; Unlock
+        L -^BSDXAPPT(BSDXAPTID)
         ;
         ; Return data in ADO.net table
@@ -177 +186 @@
         ;
 ERR(BSDXERID,ERRTXT)       ;Error processing
+        ; Unlock first
+        L:$D(BSDXAPTID) -^BSDXAPPT(BSDXAPTID)
         ; If last line is $C(31), we are done. No more errors to send to client.
         I ^BSDXTMP($J,$O(^BSDXTMP($J," "),-1))=$C(31) QUIT
@@ -189 +200 @@
         N $ET S $ET="D ^%ZTER HALT"  ; Emergency Error Trap
         D ^%ZTER
-        S $EC="" ; Clear Error
+        ;
         I $G(BSDXAPTID),$D(BSDXNS) N % S %=$$BSDXNOS(BSDXAPTID,'BSDXNS) ; Reverse No-Show status (whatever it was)
         ; Send to client